Use ImportResolver for tag imports #8254
Open
+159
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenfontanella
force-pushed
the
tag-import
branch
from
f67ef57 to
04ab34d
Compare
stevenfontanella
force-pushed
the
tag-import
branch
from
d5af3e5 to
f050e53
Compare
stevenfontanella
changed the title
tlively
reviewed
Feb 3, 2026
| virtual RuntimeTable* getTableOrNull(ImportNames name, | ||
| const Table& type) const = 0; | ||
|
|
||
| virtual Tag* getTagOrNull(ImportNames name, const Signature& type) const = 0; |
Member
There was a problem hiding this comment.
We're also going to need some kind of RuntimeTag abstraction, since multiple instances of the same modules generate distinct instantiations of the same tag definition.
Would that be better handled now or in a follow-up?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8180