Fix mpm depth handling #507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjy5
force-pushed
the
fix-mpm-depth-handling
branch
from
1871096 to
bcac096
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes depth handling for the MPM (Pathfinder MPM) platform binding to correctly handle coordinate space transformations.
Key Changes:
- Added transformation of input depth from unified to platform space (line 209)
- Added transformation of return depth from platform to unified space (line 248)
- Version bumped from 2.2.1 to 2.2.2
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/ephys_link/bindings/mpm_binding.py |
Fixed set_depth method to properly convert between unified and platform coordinate spaces, accounting for MPM's inverted w-axis |
src/ephys_link/__about__.py |
Bumped version to 2.2.2 for this bug fix release |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Notes