fix bug where part of template annotation line was not stripped #2556
+3
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelhawksley
force-pushed
the
fix-segfault-compiled-source
branch
3 times, most recently
from
c6f7212 to
ff5dabb
Compare
In #2541, logic was added to strip out the first template annotation line. Unfortunately, the template annotations in Rails span multiple lines, causing invalid Ruby to be eval'd. This fix splits the compiled source on ";", which properly isolates the template annotation for easy removal.
joelhawksley
force-pushed
the
fix-segfault-compiled-source
branch
from
ff5dabb to
2750a14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2541, logic was added to strip out the first template annotation line. Unfortunately, the template annotations in Rails span multiple lines, causing invalid Ruby to be eval'd.
This fix splits the compiled source on ";", which properly isolates the template annotation for easy removal.
@george-bit I haven't completely isolated the issue yet, but in #2555, I added a
raiseto prove that@strip_annotation_lineis false on Rails/Ruby main.