Skip to content

Fix coverage(eval) segfault when annotations are disabled #2553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joshsadam wants to merge 2 commits into from
+8 −2
Closed

Fix coverage(eval) segfault when annotations are disabled #2553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc20ca6
Fix coverage eval segfault when view annotations are disabled
joshsadam Feb 12, 2026
a352525
Guard negative eval lineno during coverage in compile_to_component
joshsadam Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ nav_order: 6

## main

* Fix segfault when coverage of eval'd code is enabled with Rails 8.1 ERB templates and view annotations are disabled.

*Josh Adam*

* Add `protocol` parameter to `with_request_url` test helper to enable testing with HTTPS protocol.

*Joel Hawksley*
Expand Down
4 changes: 3 additions & 1 deletion lib/view_component/template.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,10 @@ def defined_on_self?
def compile_to_component
@component.silence_redefinition_of_method(call_method_name)

safe_lineno = coverage_running? && @lineno.to_i.negative? ? 1 : @lineno

# rubocop:disable Style/EvalWithLocation
@component.class_eval <<~RUBY, @path, @lineno
@component.class_eval <<~RUBY, @path, safe_lineno
def #{call_method_name}
#{compiled_source}
end
Expand Down
2 changes: 1 addition & 1 deletion test/sandbox/test/inline_template_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ class InlineComponentDerivedFromComponentSupportingVariants < Level2Component
def with_coverage_running
require "coverage"
already_running = Coverage.running?
Coverage.start unless already_running
Coverage.start(lines: true, branches: true, eval: true) unless already_running
yield
ensure
Coverage.result unless already_running
Expand Down