Skip to content

fix issue #68 #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OPADA-Eng wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix issue #68 #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da4e074
fix issues #68
OPADA-Eng Nov 13, 2019
1afad2d
fix
Sep 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ios-ts-lib/helpers.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions ios-ts-lib/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import * as types from 'tns-core-modules/utils/types';
import * as utils from 'tns-core-modules/utils/utils';
import * as fs from 'tns-core-modules/file-system';
import * as appSettings from 'tns-core-modules/application-settings';
import * as imageSource from 'tns-core-modules/image-source';

// import * as imageSource from 'tns-core-modules/image-source';
import { ImageSource } from "tns-core-modules/image-source";


declare class UIViewContentMode {
Expand Down Expand Up @@ -53,7 +53,7 @@ export class Helpers {
});
} else if (utils.isFileOrResourcePath(value)) {
image.isLoading = true;
let source: any = new imageSource.ImageSource();
let source: any = new ImageSource();

if (0 === value.indexOf(utils.RESOURCE_PREFIX)) {
let path = value.substr(utils.RESOURCE_PREFIX.length);
Expand All @@ -77,7 +77,7 @@ export class Helpers {
public static getPlaceholderUIImage(value) {
if (types.isString(value)) {
if (utils.isFileOrResourcePath(value)) {
return imageSource.fromFileOrResource(value).ios;
return ImageSource.fromFileOrResource(value).ios;
}
}

Expand Down
2 changes: 1 addition & 1 deletion platforms/android/include.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ android {
}

dependencies {
compile "com.facebook.fresco:fresco:1.10.0"
compile "com.facebook.fresco:fresco:2.1.0"
}