-
Notifications
You must be signed in to change notification settings - Fork 20
feat: conversational agent support #1087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mike-deem-uipath
wants to merge
1
commit into
main
Choose a base branch
from
feat/conv-agent-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -69,6 +69,11 @@ | |
| default=5678, | ||
| help="Port for the debug server (default: 5678)", | ||
| ) | ||
| @click.option( | ||
| "--keep-state-file", | ||
| is_flag=True, | ||
| help="Keep the state file even when not resuming and no job id is provided", | ||
| ) | ||
| def run( | ||
| entrypoint: str | None, | ||
| input: str | None, | ||
|
|
@@ -79,6 +84,7 @@ def run( | |
| trace_file: str | None, | ||
| debug: bool, | ||
| debug_port: int, | ||
| keep_state_file: bool, | ||
| ) -> None: | ||
| """Execute the project.""" | ||
| input_file = file or input_file | ||
|
|
@@ -147,6 +153,7 @@ async def execute() -> None: | |
| resume=resume, | ||
| command="run", | ||
| trace_manager=trace_manager, | ||
| keep_state_file=keep_state_file, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| ) | ||
|
|
||
| if ctx.trace_file: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's replace this with:
Trying to shoot two birds with one stone, if we have this specified, we just use it as an override and don't delete it. Updated the runtime PR as well https://github.com/UiPath/uipath-runtime-python/pull/65/changes
We need to update the
pyproject.tomlwith the new runtime version range + increment the minor here as wellThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now if I want to keep the file, I have to know and provide the path to it? This doesn't make sense to me... the file you want to use and if you want to keep it are separate concepts.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is where the keep-state-file flag was used: https://github.com/UiPath/uipath-langchain-python/pull/395/changes#diff-7533e122e0f409dfcb61aa90e55e348bb528eac57d711599e88b198f38a467adR70. So this becomes
self.context.state_file_path is not None. Why would one expect just setting that property to have the side effect of not deleting the file? And what if I want the file to be deleted AND I want to override the path?Having an explicit keep-state-file flag avoids these unexpected side effects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need the state file pointer for something else, was thinking we can re-use the concept for this as well, and avoid adding another option.
If you insist, you can add the keep-state-file option back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea behind my thoughts is that you either: