-
Notifications
You must be signed in to change notification settings - Fork 29
feat: improve hitl details #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| """Generate the agent execution viewer URL based on execution context. | ||
| Args: | ||
| cloud_base_url: Optional cloud base URL. If not provided, will be extracted from environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is outdated, right?
| Returns: | ||
| The constructed viewer URL for the agent execution. | ||
| Note: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this note as well - please update these docs
| return "PostExecution" | ||
|
|
||
|
|
||
| def _get_agent_execution_viewer_url() -> tuple[str, str]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have 2 different functions for url and tenant name? Currently it's a bit hidden that this func returns the tenant name too
Development Package