Update import path for GPIO in STM32 example#663
Open
Gabriela3456 wants to merge 16 commits intoUPB-PMRust:mainfrom
Open
Update import path for GPIO in STM32 example#663Gabriela3456 wants to merge 16 commits intoUPB-PMRust:mainfrom
Gabriela3456 wants to merge 16 commits intoUPB-PMRust:mainfrom
Conversation
alexandruradovici
requested changes
Oct 26, 2025
Contributor
alexandruradovici
left a comment
alexandruradovici
left a comment
There was a problem hiding this comment.
This should be modified to have tabs for Input, @Gabriela3456 can you add tabs at the input section?
Co-authored-by: Alexandru Radovici <msg4alex@gmail.com>
alexandruradovici
requested changes
Oct 27, 2025
Contributor
alexandruradovici
left a comment
alexandruradovici
left a comment
There was a problem hiding this comment.
Can you add tabs for the Input pins? Right now there are no tabs and the example is only for the stm32. The functions should be identical, the imports differ. Take a look at https://github.com/embassy-rs/embassy/blob/main/examples/rp/src/bin/button.rs .
Contributor
|
@Gabriela3456 kind reminder |
Added example code for using GPIO input with pull-up.
alexandruradovici
requested changes
Nov 3, 2025
Updated GPIO input initialization for STM32 and Raspberry Pi Pico examples.
Add example code for STM32 Nucleo-U545RE-Q tab.
alexandruradovici
requested changes
Nov 3, 2025
Added example code for GPIO input configuration on Raspberry Pi Pico.
alexandruradovici
requested changes
Nov 18, 2025
alexandruradovici
requested changes
Nov 18, 2025
Updated comments for clarity on pin initialization.
alexandruradovici
requested changes
Nov 19, 2025
Updated comment formatting for clarity.
Clarify comment to specify setting the internal pull-up resistor.
alexandruradovici
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Name: Julean Diana-Gabriela
Group: 1241EC
This pull request fixes a gpio import
Testing Strategy
This pull request was tested by @Gabriela3456
TODO or Help Wanted
N/A
Build
./build.sh../website_build.sh.Author
Signed-off-by: Julean Diana-Gabriela diana.julean@stud.fils.upb.ro