fix(ui5-split-button): resolve nested interactive elements and invalid aria references #12977
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d aria references
Collaborator
|
🚀 Deployed on https://pr-12977--ui5-webcomponents-preview.netlify.app |
unazko
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The
ui5-ai-buttonusesui5-split-buttoninternally. When the arrow button is hidden (_hideArrowButton=true), two accessibility violations occur:role="button"containing a<button>childaria-labelledbypoints to IDs that don't exist in the DOMWhat We Did
Change the wrapper role to
"presentation"and makearia-labelledbyconditional when arrow button is hidden:What This Fixes
aria-labelledbyonly references existing IDs