Skip to content

fix(ui5-timeline): add correct accessibleName to growing button #12963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hinzzx wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(ui5-timeline): add correct accessibleName to growing button #12963

hinzzx wants to merge 2 commits into from

Conversation

@hinzzx
Copy link
Contributor

@hinzzx hinzzx commented Jan 27, 2026 •
edited
Loading

Problem

The ui5-timeline "Load More" button (displayed when growing="Button") is an icon-only button with no accessible name or tooltip:

  1. Screen readers announce only the icon's generic name ("Process" or "Drill Down") instead of the button's purpose
  2. Visual tooltip on hover shows the icon name, not the action
  3. Region label was hardcoded as "Timeline", ignoring the accessibleName property

Solution

  • Added tooltip and accessibleName properties to the growing button with i18n text "Load More"
  • Changed region's aria-label from hardcoded "Timeline" to dynamic this.ariaLabel

What This Fixes

  • ✅ Screen readers now announce "Load More" (i18n-enabled)
  • ✅ Visual tooltip shows "Load More" on hover
  • ✅ Consistent UX between sighted and screen reader users
  • ✅ Timeline region label respects accessibleName property

@hinzzx hinzzx changed the title fix(ui5-timeline): add correct to growing button fix(ui5-timeline): add correct aria-label to growing button Jan 27, 2026
@ui5-webcomponents-bot
Copy link
Collaborator

ui5-webcomponents-bot commented Jan 27, 2026 •
edited
Loading

🚀 Deployed on https://pr-12963--ui5-webcomponents-preview.netlify.app

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview January 27, 2026 07:57 Inactive
@hinzzx hinzzx changed the title fix(ui5-timeline): add correct aria-label to growing button fix(ui5-timeline): add correct accessibleName to growing button Jan 27, 2026
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview January 30, 2026 07:58 Inactive
@unazko unazko self-requested a review January 30, 2026 08:14
@unazko unazko requested a review from tsanislavgatev January 30, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@unazko unazko unazko approved these changes

@tsanislavgatev tsanislavgatev Awaiting requested review from tsanislavgatev

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hinzzx @ui5-webcomponents-bot @unazko