fix(framework): invalidation of unchanged slots #10949
Closed
+60
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@nnaydenow it seems like TableGrowing.cy is among the tests that are failing for your PR. I've created another PR that solves the issue, you can review it here: #10952 |
Collaborator
|
🧹 Preview deployment cleaned up: https://pr-10949--ui5-webcomponents.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
_updateSlotswas called twice — once by a DOM observer monitoring the custom element’s DOM node and once by the slot change event triggered insideshadowRoot.This update enhances the DOM observer to also monitor the
slotattribute of each child within the custom element’s DOM node, eliminating the need for an event listener insideshadowRoot.Fixes: #10377