Use get_stylesheet_directory() for override folders in child theme#2
Open
JSn1nj4 wants to merge 1 commit intoTypeRocket:mainfrom
Open
Use get_stylesheet_directory() for override folders in child theme#2JSn1nj4 wants to merge 1 commit intoTypeRocket:mainfrom
JSn1nj4 wants to merge 1 commit intoTypeRocket:mainfrom
Conversation
Author
|
I realized this morning that this isn't foolproof. It does handle the case of a child theme being the active one, but it won't fall back to the parent theme if the child theme doesn't have the override folders. Do you prefer covering both cases? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When a child theme is active, the TypeRocket plugin will currently check the parent theme for override folders. This is because the function
get_template_directory()will find the parent of a child theme if a child theme is active.Source:
get_template_directory()functionSolution
Use the function
get_stylesheet_directory()instead as recommended by the above docs.