Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 13, 2026

The login page was exposed as /login.jsp while all other pages use *.html URL mapping through the filenameController.

Changes

  • Relocated login.jsp from webapp root to /WEB-INF/pages/ to work with existing URL mapping (/login.html → view name login/WEB-INF/pages/login.jsp)

  • Updated Spring Security configs (treebase-security.xml, top-security.xml):

    • login-page, authentication-failure-url, logout-success-url/login.html
  • Updated controller redirects in treebase-servlet.xml:

    • registerUserController success/cancel views
    • resetPasswordController success view
  • Updated JSP references (defaultSearchTemplate.jsp, passwordForm.jsp, resetPasswordForm.jsp)

  • Updated Java code (DryadImportor.java import URL, ResetPasswordController.java comment)

  • Removed obsolete volume mount in docker-compose.yml

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • getahead.org
    • Triggering command: /opt/hostedtoolcache/CodeQL/2.23.8/x64/codeql/tools/linux64/java/bin/java /opt/hostedtoolcache/CodeQL/2.23.8/x64/codeql/tools/linux64/java/bin/java -jar /opt/hostedtoolcache/CodeQL/2.23.8/x64/codeql/xml/tools/xml-extractor.jar --fileList=/home/REDACTED/work/treebase/.codeql-scratch/dbs/java/working/files-to-index5029294666093260893.list --sourceArchiveDir=/home/REDACTED/work/treebase/.codeql-scratch/dbs/java/src --outputDir=/home/REDACTED/work/treebase/.codeql-scratch/dbs/java/trap/java (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Why is it the link to login as exposed in the web app login.jsp instead of login.html? All other pages are mapped to *.html.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

- Move login.jsp from webapp root to WEB-INF/pages/
- Update Spring Security configs to use /login.html
- Update controller redirects in treebase-servlet.xml
- Update JSP templates and form pages
- Update Java code references
- Update docker-compose.yml

Co-authored-by: rvosa <106490+rvosa@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix login page extension from JSP to HTML Change login page URL from login.jsp to login.html Jan 13, 2026
Copilot AI requested a review from rvosa January 13, 2026 10:36
@rvosa
Copy link
Contributor

rvosa commented Jan 13, 2026

@copilot this seems like a lot of work. Why was it the way it was before? Should we just stick with that?

Copy link
Contributor Author

Copilot AI commented Jan 13, 2026

@copilot this seems like a lot of work. Why was it the way it was before? Should we just stick with that?

The original issue asked why login.jsp was exposed directly while all other pages use *.html URLs via the filenameController. I interpreted this as a request to fix the inconsistency.

The original approach likely existed because login.jsp was placed at the webapp root (outside /WEB-INF/pages/) for direct access, while Spring Security was configured to reference it directly. This worked fine but was inconsistent with other pages.

If you prefer to keep the original approach, I can revert all changes. The URL inconsistency doesn't break functionality - it's purely a matter of consistency. Let me know if you'd like me to undo these changes.

@rvosa rvosa closed this Jan 13, 2026
@rvosa rvosa deleted the copilot/fix-login-file-extension branch January 13, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants