Skip to content

Comments

fix: allow forwarded messages with media in media-only channels#1419

Open
VlaM5 wants to merge 4 commits intoTogether-Java:developfrom
VlaM5:fix/forward-media-to-media-channel
Open

fix: allow forwarded messages with media in media-only channels#1419
VlaM5 wants to merge 4 commits intoTogether-Java:developfrom
VlaM5:fix/forward-media-to-media-channel

Conversation

@VlaM5
Copy link

@VlaM5 VlaM5 commented Feb 23, 2026

Fixes #1243

Forwarded messages that contain media (attachments, embeds, or links)
were incorrectly deleted in media-only channels, because the bot only
checked the message itself, not its MessageSnapshots.

Changes:

  • Extended messageHasNoMediaAttached() to also check MessageSnapshot contents
  • Extracted hasMedia() helper method for reuse
  • Added tests for forwarded messages with and without media

@VlaM5 VlaM5 requested a review from a team as a code owner February 23, 2026 13:06
@CLAassistant
Copy link

CLAassistant commented Feb 23, 2026

CLA assistant check
All committers have signed the CLA.

@VlaM5 VlaM5 requested a review from Zabuzard February 23, 2026 16:13
Zabuzard
Zabuzard previously approved these changes Feb 24, 2026
@Zabuzard
Copy link
Member

Zabuzard commented Feb 24, 2026

nice stuff, thanks. just make the CI/CD happy and we can get it merged soon :)

@Zabuzard
Copy link
Member

poggers, all green 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to forward messages with images to media channels

3 participants