Deprioritize the Vec container#664
Merged
frankmcsherry merged 6 commits intoTimelyDataflow:masterfrom Feb 8, 2026
Merged
Conversation
frankmcsherry
commented
Feb 7, 2026
Comment on lines
-209
to
+210
| /// .reduce(move |_key, src, dst| dst.push((*src[0].0, 1))); | ||
| /// .reduce_abelian::<_,ValBuilder<_,_,_,_>,ValSpine<_,_,_,_>>("Reduce", |_key, src, dst| dst.push((*src[0].0, 1))) | ||
| /// .as_collection(|k,v| (k.clone(), v.clone())); |
Member
Author
There was a problem hiding this comment.
To call out, this is an example where things are more tedious than before, as there isn't an easy way to get something that defaults to 1. any trace at all, and 2. vector output. This feels like an ergonomic nit we could fix, e.g. with some method on arrangements that are vec appropriate, so that type inference would drive it.
715d66b to
8e4213f
Compare
8e4213f to
2b517dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR imagines deprioritizing the
VecCollectiontype that is a stream around aVeccontainer.Specifically, we group together the methods on
VecCollectionin their ownmod vec, and migrate the vector specific parts ofreduce.rshere. TheReduce(and others) traits that produce streams with vector containers are made inherent methods onVecCollection, and are not surfaced as traits.There are trade-offs here:
I didn't go as far as doing the same thing with
join.rs, as the output type there is inherently not an arrangement, and it's not as clear how to pilot the joining of arrangements to success without insisting on a container builder. Perhaps that's right, and the right thing to do, but also wanted to share this before going too deep.