-
Notifications
You must be signed in to change notification settings - Fork 343
Add Gateway Fleet support in the Console OS #7776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for Gateway Fleet management in the Console OS by introducing the ability to choose between gateway owner tokens and fleet owner tokens when claiming managed gateways. The implementation includes UI enhancements for token type selection and improved error messaging to guide users toward using Fleet Owner Tokens when appropriate.
Key Changes
- Added a toggle switch UI for selecting between gateway and fleet owner token types when claiming managed gateways
- Enhanced QR code scanning flow to support optional fleet owner token input via a new "Add to Fleet" button in the scan modal
- Updated error messages to inform users about Fleet Owner Token usage when subscription issues occur
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
pkg/webui/styles/utilities/general.styl |
Added utility CSS classes for height, flex-basis, white-space, and hover effects |
pkg/webui/locales/ja.json |
Added empty translation placeholders for new fleet-related messages |
pkg/webui/locales/en.json |
Added English translations for fleet token UI elements and updated error messages |
pkg/webui/lib/shared-messages.js |
Added shared messages for fleet information and token descriptions |
pkg/webui/lib/errors/utils.js |
Updated subscription error message to mention Fleet Owner Token option, removed activation code expired message |
pkg/webui/console/containers/gateway-onboarding-form/qr-scan-section/index.js |
Enhanced QR scan handler to fetch gateway managed status and populate fleet token fields |
pkg/webui/console/containers/gateway-onboarding-form/qr-scan-section/fleets-scan.js |
New component providing fleet owner token input UI within the QR scan modal |
pkg/webui/console/containers/gateway-onboarding-form/gateway-provisioning-form/validation-schema.js |
Added _isFleet field to validation schema |
pkg/webui/console/containers/gateway-onboarding-form/gateway-provisioning-form/gateway-claim-form-section/index.js |
Implemented tabs for switching between gateway and fleet token types with conditional UI rendering |
pkg/webui/components/tabs/tab/tab.styl |
Added styling for small tab variant |
pkg/webui/components/tabs/tab/index.js |
Added small prop support to Tab component |
pkg/webui/components/tabs/index.js |
Passed small prop to Tab children |
pkg/webui/components/qr-modal-button/index.js |
Added modalDataChildren prop to allow custom content in QR modal |
pkg/webui/components/form/field/index.js |
Added descriptionValues and showTitle props for dynamic field descriptions and conditional title rendering |
cypress/e2e/console/gateways/create.spec.js |
Updated test selectors from label-based to name-based for owner token input field |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pkg/webui/console/containers/gateway-onboarding-form/qr-scan-section/fleets-scan.js
Show resolved
Hide resolved
...ainers/gateway-onboarding-form/gateway-provisioning-form/gateway-claim-form-section/index.js
Outdated
Show resolved
Hide resolved
...ainers/gateway-onboarding-form/gateway-provisioning-form/gateway-claim-form-section/index.js
Show resolved
Hide resolved
pkg/webui/console/containers/gateway-onboarding-form/qr-scan-section/fleets-scan.js
Show resolved
Hide resolved
|
Add link to Slot docs. |
|
Add hash or param to SM dashboard url |
|
@ryaplots I am not able to view the screenshots in the result section. |
|
@RishiRamMeesala what about like this:
|





Summary
References https://github.com/TheThingsIndustries/lorawan-stack/issues/4760
Changes
Testing
Steps
a. Click the button and fill in a fleet owner token -> After approving the modal, the fleet token should be filled and "fleet" selected in the toggle.
b. Do not click the button -> After approving the modal, the gateway owner token should be filled and "gateway" selected in the toggle.
Results
Screeshots
Checklist
README.mdfor the chosen target branch.CHANGELOG.md.CONTRIBUTING.md, there are no fixup commits left.