bugfix: Update visibility conditions for client-side effects #1964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stubbjax
added
Bug
xezon
reviewed
Dec 10, 2025
xezon
reviewed
Dec 13, 2025
| if (TheControlBar->isObserverControlBarOn()) | ||
| { | ||
| const Player* observedPlayer = TheControlBar->getObserverLookAtPlayer(); | ||
| if (!observedPlayer || !observedPlayer->isPlayerActive()) |
There was a problem hiding this comment.
Is this test really necessary? If this was missing, what would be broken?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1919
This change adjusts income text, veterancy animations and weapon effect conditions so that they play irrespective of an object's drawable / rendering state or being within the view frustum.
Bomb Truck effects now consistently play during their disguise transition states for other players as an added bonus. See #1919 for more information.