Skip to content

Conversation

@jsurrea
Copy link
Collaborator

@jsurrea jsurrea commented Apr 11, 2025

No description provided.

@jsurrea jsurrea self-assigned this Apr 11, 2025
@jsurrea jsurrea requested a review from Copilot April 12, 2025 01:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 68 out of 71 changed files in this pull request and generated 1 comment.

Files not reviewed (3)
  • antares-python/.gitignore: Language not supported
  • antares-python/.python-version: Language not supported
  • antares-python/template.env: Language not supported
Comments suppressed due to low confidence (1)

antares-python/src/antares/models/track.py:20

  • Using 'range' as a field name can shadow the built-in range() function. Consider renaming it (e.g., 'track_range' or 'distance') to avoid potential confusion.
    range: float

@jsurrea jsurrea requested a review from Copilot April 12, 2025 03:02
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 69 out of 71 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • antares-python/.gitignore: Language not supported
  • antares-python/.python-version: Language not supported
Comments suppressed due to low confidence (2)

antares-python/src/antares/cli.py:91

  • [nitpick] The use of the parameter name 'type' shadows the built-in 'type'; consider renaming it to 'ship_type' to improve clarity.
def add_ship(  # noqa: PLR0913

antares-python/src/antares/models/track.py:16

  • [nitpick] For consistency with ship model definitions, consider aligning the field name with the ship models (which use 'type') or ensure documentation clearly explains the use of 'type_' in this context.
type_: str = Field(alias="type")  # maps from "type" input

@jsurrea jsurrea merged commit ba1ccac into main Apr 12, 2025
2 checks passed
@jsurrea jsurrea deleted the Improvements branch May 7, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants