Transition commands from ACF to Cloud #1029
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonytheMacaroni
force-pushed
the
cloud-commands
branch
10 times, most recently
from
71e9ac1 to
752d08a
Compare
TonytheMacaroni
force-pushed
the
cloud-commands
branch
7 times, most recently
from
d3c6ecc to
df6adeb
Compare
|
Built artifact: |
core/src/main/java/com/nisovin/magicspells/commands/parsers/SpellCastArgumentsParser.java
Show resolved
Hide resolved
core/src/main/java/com/nisovin/magicspells/commands/parsers/SpellCastArgumentsParser.java
Show resolved
Hide resolved
core/src/main/java/com/nisovin/magicspells/commands/MagicCommands.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/nisovin/magicspells/commands/ResetCooldownCommand.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/nisovin/magicspells/commands/parsers/SpellCastArgumentsParser.java
Outdated
Show resolved
Hide resolved
JasperLorelai
suggested changes
Nov 17, 2025
This comment was marked as resolved.
This comment was marked as resolved.
TonytheMacaroni
force-pushed
the
cloud-commands
branch
from
36af17f to
734fb7a
Compare
JasperLorelai
suggested changes
Dec 5, 2025
JasperLorelai
left a comment
JasperLorelai
left a comment
There was a problem hiding this comment.
I also want to suggest these changes, which couldn't be part of the GitHub Review thingy. After that, I'd say this is ready for merging after B18's release.
Some future ideas we should consider:
- Adding string Spell FIlter support to
/ms resetcd. - Adding
*support to<variable>of/ms variable modify. - Adding multiple player support to more commands because selectors are powerful.
After requested changes, would you say this changelog is accurate?
Breaking Changes:
- Removed
/ms util download/update/saveskinand their permissions (magicspells.command.util.download/update/saveskin). /ms magicitemsyntax changed from<magicItem> [amount] [player]to<players> <magicItem> [amount] --drop-leftover.- The
-p:<power>flag has changed on/ms castcommands to--power <power>or-p <power>.
Changes:
- All commands now support MC entity selectors.
/ms reload [players]- now supports multiple entities./ms resetcd- now supports multiple living entities and offline players instead of just an online player./ms mana reset/add/set/updaterank- now supports multiple players./ms cast as/on- now supports a living entity selector instead of just a player./ms cast at- now supports the tilde (~) and caret (^) notation for coordinates,--powerflag, as well as[spellArgs].
core/src/main/java/com/nisovin/magicspells/commands/VariableCommands.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/nisovin/magicspells/commands/TaskInfoCommand.java
Show resolved
Hide resolved
TonytheMacaroni
force-pushed
the
cloud-commands
branch
from
bcb63d6 to
f2b5d88
Compare
TonytheMacaroni
force-pushed
the
cloud-commands
branch
from
f2b5d88 to
deb5baf
Compare
TonytheMacaroni
force-pushed
the
cloud-commands
branch
from
deb5baf to
f45e0ef
Compare
JasperLorelai
suggested changes
Dec 16, 2025
JasperLorelai
left a comment
JasperLorelai
left a comment
There was a problem hiding this comment.
There's just these changes left, from what I can tell.
| import org.bukkit.Bukkit; | ||
| import org.bukkit.event.Listener; | ||
| import org.bukkit.configuration.file.YamlConfiguration; | ||
| import org.bukkit.plugin.Plugin; |
|
|
||
| import org.bukkit.event.Listener; | ||
| import org.bukkit.configuration.file.YamlConfiguration; | ||
| import org.bukkit.plugin.Plugin; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.