Add start of week as new option in models #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winsmith
approved these changes
Jul 15, 2024
Contributor
winsmith
left a comment
winsmith
left a comment
There was a problem hiding this comment.
Looks good, so feel free to merge, but I'm afraid I'll have to postpone the other PRs until I have a bit of breathing room
Contributor
Author
|
@winsmith I don't feel comfortable merging this without you having had a proper look. I don't feel confident about this PR. I have a feeling there could be a better way to implement this whole thing, so I'll wait with the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of multiple PRs targeting TelemetryDeck/SwiftDateOperations#1.
Other PRs to check: