-
Notifications
You must be signed in to change notification settings - Fork 27
LE1 add doenets for vector operations #908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Preview available 🚀https://8d0a6b40.tbil.pages.dev
|
|
I like the idea. Would it make more sense to incorporate the interactives into examples though? Maybe Example 1.1.4 does addition algebraically and then the first interactive, and add an Example 1.1.5 that does scalar multiplication algebraically and then the second interactive. |
| </example> | ||
| <figure xml:id="figure-le1-add-vectors"> | ||
| <caption>Visualization of adding vectors</caption> | ||
| <interactive label="LE1-interactive-add-vectors" platform="doenetml" width="100%"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these need <descriptions> or are they otherwise navigable by screen readers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am waiting on https://groups.google.com/g/pretext-a11y/c/PtHHq-CCBJo / https://discordapp.com/channels/1119039531564417084/1377810920079888456/1461070765406294048 to be answered so I can do this. Perhaps we can merge this as-is, but open an issue to add descriptions generally?
siwelwerd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow-up from our synchronous conversation: Each <interactive> should have a <description>. See also above suggestion about reorganizing into two examples.
I think it went well enough today that I'm going to keep it as-is for now. |
|
Stylistically I think maybe they still belong to the above example? Even if that's just moving the
Sounds good, throw your proposed |
No description provided.