Skip to content

Conversation

@StevenClontz
Copy link
Contributor

No description provided.

@github-actions
Copy link

🚀 Preview available 🚀

https://8d0a6b40.tbil.pages.dev

@siwelwerd
Copy link
Contributor

I like the idea. Would it make more sense to incorporate the interactives into examples though? Maybe Example 1.1.4 does addition algebraically and then the first interactive, and add an Example 1.1.5 that does scalar multiplication algebraically and then the second interactive.

</example>
<figure xml:id="figure-le1-add-vectors">
<caption>Visualization of adding vectors</caption>
<interactive label="LE1-interactive-add-vectors" platform="doenetml" width="100%">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these need <descriptions> or are they otherwise navigable by screen readers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am waiting on https://groups.google.com/g/pretext-a11y/c/PtHHq-CCBJo / https://discordapp.com/channels/1119039531564417084/1377810920079888456/1461070765406294048 to be answered so I can do this. Perhaps we can merge this as-is, but open an issue to add descriptions generally?

Copy link
Contributor

@siwelwerd siwelwerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up from our synchronous conversation: Each <interactive> should have a <description>. See also above suggestion about reorganizing into two examples.

@StevenClontz
Copy link
Contributor Author

I like the idea. Would it make more sense to incorporate the interactives into examples though? Maybe Example 1.1.4 does addition algebraically and then the first interactive, and add an Example 1.1.5 that does scalar multiplication algebraically and then the second interactive.

I think it went well enough today that I'm going to keep it as-is for now.

@siwelwerd
Copy link
Contributor

Stylistically I think maybe they still belong to the above example? Even if that's just moving the </example> down. Will approve and let you decide before merging though.

Perhaps we can merge this as-is, but open an issue to add descriptions generally?

Sounds good, throw your proposed <description> in a commit on #909 , and when we get an answer I'll handle them all together.

@StevenClontz StevenClontz merged commit fe2f273 into main Jan 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants