WIP: chore: update tanstack start #690
Conversation
👷 Deploy request for tanstack pending review.Visit the deploys page to approve it
|
| params: { libraryId, version } as never, | ||
| }) | ||
| } | ||
| return undefined as never |
There was a problem hiding this comment.
hmm this seems a bit weird
| "@tanstack/react-router": "1.157.16", | ||
| "@tanstack/react-router-devtools": "1.157.16", | ||
| "@tanstack/react-router-ssr-query": "1.157.16", | ||
| "@tanstack/react-start": "1.157.16", |
There was a problem hiding this comment.
upgrade react router
| "react": "^19.2.4", | ||
| "react-colorful": "^5.6.1", | ||
| "react-dom": "^19.2.0", | ||
| "react-dom": "^19.2.4", |
src/components/landing/DbLanding.tsx
Outdated
| to: './docs', | ||
| params: { libraryId: library.id }, | ||
| to: '/$libraryId/$version/docs', | ||
| params: { libraryId: library.id, version: 'latest' }, |
There was a problem hiding this comment.
why is "latest" added here?
There was a problem hiding this comment.
yeah that is odd doesn't look like it needs it. The version will just default to latest?
src/components/landing/DbLanding.tsx
Outdated
| to: './docs', | ||
| params: { libraryId: library.id }, | ||
| to: '/$libraryId/$version/docs', | ||
| params: { libraryId: library.id, version: 'latest' }, |
There was a problem hiding this comment.
why is "latest" added here?
| to: './docs', | ||
| params: { libraryId: library.id }, | ||
| to: '/$libraryId/$version/docs', | ||
| params: { libraryId: library.id, version: 'latest' }, |
| to: './docs', | ||
| params: { libraryId: library.id }, | ||
| to: '/$libraryId/$version/docs', | ||
| params: { libraryId: library.id, version: 'latest' }, |
There was a problem hiding this comment.
i see this happened a lot, wont repeat this comment all over :D
There was a problem hiding this comment.
I removed this in the latest commit
src/components/ShowcaseSection.tsx
Outdated
| <Link | ||
| to="/showcase" | ||
| search={{ | ||
| page: 1, |
There was a problem hiding this comment.
shouldnt this be set by the routes validator?
There was a problem hiding this comment.
Updated the searchSchema's instead of the links in some cases
2 participants
Main goals:
Chores