-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Fix TanStack virtual example link #6169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
📝 WalkthroughWalkthroughA documentation URL in a comment was updated from one path structure to another in the virtualized rows example file. The change reflects a restructured documentation URL path without affecting any code behavior or functionality. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minute Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@examples/react/virtualized-rows/src/main.tsx`:
- Line 23: In the experimental example's main.tsx update the outdated comment
URL: find the string "/docs/examples/react/table" in
examples/react/virtualized-rows-experimental's main.tsx and replace it with the
new path "/docs/framework/react/examples/table" so the comment matches the
updated documentation structure.
|
|
||
| //This is a dynamic row height example, which is more complicated, but allows for a more realistic table. | ||
| //See https://tanstack.com/virtual/v3/docs/examples/react/table for a simpler fixed row height example. | ||
| //See https://tanstack.com/virtual/v3/docs/framework/react/examples/table. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
site:tanstack.com/virtual/v3/docs/framework/react/examples/table
💡 Result:
The URL you searched points to TanStack Virtual v3 → React Example: Table, which demonstrates virtualizing 50,000 rows in a <table> by combining @tanstack/react-table (row model + sorting) with @tanstack/react-virtual (useVirtualizer). It renders only the visible rows and positions each <tr> using a translateY(...) transform computed as virtualRow.start - index * virtualRow.size (table-specific offset handling). [1]
Sources: [1] (tanstack.com)
Citations:
🏁 Script executed:
#!/bin/bash
# Search for TanStack Virtual documentation URLs that may use old or new path structures
echo "=== Searching for tanstack.com/virtual references ==="
rg -n 'tanstack\.com/virtual' --type=tsx --type=ts --type=jsx --type=js --type=mdx --type=md
echo -e "\n=== Searching for /docs/examples/ pattern (old structure) ==="
rg -n '/docs/examples/' --type=tsx --type=ts --type=jsx --type=js --type=mdx --type=md
echo -e "\n=== Searching for /docs/framework/ pattern (new structure) ==="
rg -n '/docs/framework/' --type=tsx --type=ts --type=jsx --type=js --type=mdx --type=mdRepository: TanStack/table
Length of output: 339
🏁 Script executed:
#!/bin/bash
echo "=== Searching for all tanstack.com/virtual references ==="
rg -n 'tanstack\.com/virtual'
echo -e "\n=== Searching for /docs/examples/ pattern (old structure) ==="
rg -n '/docs/examples/'
echo -e "\n=== File count in examples/react/ ==="
find examples/react -type f -name "*.tsx" -o -name "*.ts" -o -name "*.jsx" -o -name "*.js" -o -name "*.md" | head -20
echo -e "\n=== Check main.tsx content ==="
cat examples/react/virtualized-rows/src/main.tsx | head -30Repository: TanStack/table
Length of output: 3785
Update the outdated documentation URL in the experimental example as well.
The updated URL at line 23 of examples/react/virtualized-rows/src/main.tsx is correct, but examples/react/virtualized-rows-experimental/src/main.tsx at line 19 still references the old path structure (/docs/examples/react/table). Update it to use the new path: /docs/framework/react/examples/table.
🤖 Prompt for AI Agents
In `@examples/react/virtualized-rows/src/main.tsx` at line 23, In the experimental
example's main.tsx update the outdated comment URL: find the string
"/docs/examples/react/table" in examples/react/virtualized-rows-experimental's
main.tsx and replace it with the new path "/docs/framework/react/examples/table"
so the comment matches the updated documentation structure.
TODO: check if there are broken links in other examples ...
Summary by CodeRabbit