-
-
Notifications
You must be signed in to change notification settings - Fork 583
fix(react-form-start): remove sensitive data logging in createServerValidate #2010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 3fc46c1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Shoot! This is a great catch. We have a massive improvement/overhaul on server functions coming soon, but I'll merge this before then. |
|
BTW, can you take a look here and try it out and LMK what you think? |
|
View your CI Pipeline Execution ↗ for commit 3fc46c1
☁️ Nx Cloud last updated this comment at |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2010 +/- ##
==========================================
- Coverage 90.35% 0.00% -90.36%
==========================================
Files 38 5 -33
Lines 1752 48 -1704
Branches 444 8 -436
==========================================
- Hits 1583 0 -1583
+ Misses 149 43 -106
+ Partials 20 5 -15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🎯 Changes
Removed a
console.logstatement insrc/createServerValidate.tsxthat was logging the whole data object and props during server-side validation. This object can contain sensitive information such as formData, passwords, or other PII, which should not be exposed in server logs.
Motivation: To prevent sensitive data leaks in server-side logs and improve the security of the library.
✅ Checklist
pnpm test:pr.🚀 Release Impact