Skip to content

Conversation

@iddriss
Copy link
Contributor

@iddriss iddriss commented Jan 30, 2026

🎯 Changes

Removed a console.log statement in
src/createServerValidate.tsx
that was logging the whole data object and props during server-side validation. This object can contain sensitive information such as formData, passwords, or other PII, which should not be exposed in server logs.

Motivation: To prevent sensitive data leaks in server-side logs and improve the security of the library.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2026

🦋 Changeset detected

Latest commit: 3fc46c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@tanstack/react-form-start Patch
@tanstack/form-core Patch
@tanstack/react-form Patch
@tanstack/react-form-remix Patch
@tanstack/react-form-nextjs Patch
@tanstack/angular-form Patch
@tanstack/vue-form Patch
@tanstack/solid-form Patch
@tanstack/svelte-form Patch
@tanstack/form-devtools Patch
@tanstack/lit-form Patch
@tanstack/react-form-devtools Patch
@tanstack/solid-form-devtools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@iddriss iddriss changed the title fix(createServerValidate): remove sensitive data logging fix(react-form-start): remove sensitive data logging in createServerValidate Jan 30, 2026
@crutchcorn
Copy link
Member

Shoot! This is a great catch. We have a massive improvement/overhaul on server functions coming soon, but I'll merge this before then.

@crutchcorn
Copy link
Member

BTW, can you take a look here and try it out and LMK what you think?

#1890

@nx-cloud
Copy link

nx-cloud bot commented Jan 30, 2026

View your CI Pipeline Execution ↗ for commit 3fc46c1

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 26s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 4s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-30 03:16:16 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 30, 2026

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@2010

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@2010

@tanstack/form-devtools

npm i https://pkg.pr.new/@tanstack/form-devtools@2010

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@2010

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@2010

@tanstack/react-form-devtools

npm i https://pkg.pr.new/@tanstack/react-form-devtools@2010

@tanstack/react-form-nextjs

npm i https://pkg.pr.new/@tanstack/react-form-nextjs@2010

@tanstack/react-form-remix

npm i https://pkg.pr.new/@tanstack/react-form-remix@2010

@tanstack/react-form-start

npm i https://pkg.pr.new/@tanstack/react-form-start@2010

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@2010

@tanstack/solid-form-devtools

npm i https://pkg.pr.new/@tanstack/solid-form-devtools@2010

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@2010

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@2010

commit: 3fc46c1

@sentry
Copy link

sentry bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (6892ed0) to head (3fc46c1).
⚠️ Report is 127 commits behind head on main.

Files with missing lines Patch % Lines
...ages/react-form-start/src/createServerValidate.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2010       +/-   ##
==========================================
- Coverage   90.35%   0.00%   -90.36%     
==========================================
  Files          38       5       -33     
  Lines        1752      48     -1704     
  Branches      444       8      -436     
==========================================
- Hits         1583       0     -1583     
+ Misses        149      43      -106     
+ Partials       20       5       -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@crutchcorn crutchcorn merged commit bc13bad into TanStack:main Jan 30, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants