fix(db): prevent JOIN lazy loading from accumulating duplicate loadedSubsets #1205
+291
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Subsets When using JOIN queries with on-demand sync mode, the lazy loading optimization for JOINs was accumulating LoadSubsetOptions in subscription.loadedSubsets without deduplication. Over multiple graph runs, this caused query keys and SQL queries to grow unboundedly, eventually causing "too many SQL variables" errors. Changes: - Add loadedJoinKeys Set in joins.ts to track already-loaded join keys - Filter out loaded keys before calling requestSnapshot - Add isPredicateSubset check in subscription.ts before pushing to loadedSubsets - Add tests for JOIN lazy loading deduplication Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using JOIN queries with on-demand sync mode, the lazy loading optimization for JOINs was accumulating LoadSubsetOptions in subscription.loadedSubsets without deduplication. Over multiple graph runs, this caused query keys and SQL queries to grow unboundedly, eventually causing "too many SQL variables" errors.
Changes:
🎯 Changes
✅ Checklist
pnpm test:pr.🚀 Release Impact