feat(QTDI-1914): Sample dynamic schema connector. by ypiel-talend · Pull Request #1114 · Talend/component-runtime

ypiel-talend · 2025-10-22T22:33:14Z

Requirements

https://qlik-dev.atlassian.net/browse/QTDI-1914

Any code change adding any logic MUST be tested through a unit test executed with the default build
Any API addition MUST be done with a documentation update if relevant

Why this PR is needed?

What does this PR adds (design/code thoughts)?

…ement, better clazz location.

…l loaded... to continue...

…:Talend/component-runtime into ypiel/QTDI-1914_sample_connector_dyndeps

# sample-parent/sample-features/dynamic-dependencies/dynamic-dependencies-common/src/main/java/org/talend/sdk/component/sample/feature/dynamicdependencies/config/Dependency.java # sample-parent/sample-features/dynamic-dependencies/dynamic-dependencies-common/src/main/java/org/talend/sdk/component/sample/feature/dynamicdependencies/service/AbstractDynamicDependenciesService.java

…st log + add an error messae in returned strings.

…SPI is not loaded.

…Don't fail if SPI can't be loaded.

…i in not found.

…to transmit its dynamic dependencies.

…hSPI connector output records.

…cy-common module.

Copilot

Pull request overview

This PR adds a comprehensive sample connector module demonstrating dynamic dependency loading capabilities. The implementation showcases how to use the @DynamicDependencies annotation with various configuration types (datastore, dataset, and custom configuration) and validates SPI loading from different dependency scopes.

Changes:

Added new dynamic-dependencies module with multiple sample connectors demonstrating @DynamicDependencies feature
Introduced DynamicDependenciesConfiguration annotation for marking configuration types that compute dynamic dependencies
Created supporting modules for SPI testing and classloader validation

Reviewed changes

Copilot reviewed 99 out of 110 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
sample-parent/sample-features/pom.xml	Added dynamic-dependencies module to the build
component-api/src/main/java/.../DynamicDependenciesConfiguration.java	New annotation for marking dynamic dependency configuration types
sample-parent/sample-features/dynamic-dependencies/pom.xml	Parent POM defining the dynamic-dependencies module structure
sample-parent/sample-features/dynamic-dependencies/README.md	Comprehensive documentation explaining the dynamic dependencies feature and test scenarios
sample-parent/sample-features/dynamic-dependencies/*/pom.xml	Module-specific POM files for various sample connectors
sample-parent/sample-features/dynamic-dependencies//src/main/java//.java	Implementation classes for sample connectors, services, and configuration
sample-parent/sample-features/dynamic-dependencies//src/test/java//.java	Test classes validating dynamic dependency loading

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...nt/sample/feature/dynamicdependencies/withspi/input/DynamicDependenciesWithSPIInputTest.java

.../main/java/org/talend/sdk/component/sample/feature/dynamicdependencies/config/Connector.java

...t/sample/feature/dynamicdependencies/withDynamicDependenciesConfiguration/config/Config.java

...dk/component/sample/feature/dynamicdependencies/withDataprepRunAnnotation/config/Config.java

sample-parent/sample-features/dynamic-dependencies/README.md

sonar-eks · 2026-02-02T17:29:08Z

Quality Gate failed

3.15% Duplicated Lines (%) on New Code (is greater than 3.00%)
72 New Issues (is greater than 0)

Project ID: org.talend.sdk.component:component-runtime

View in SonarQube

…nlysis.

Copilot

Pull request overview

Copilot reviewed 99 out of 110 changed files in this pull request and generated 11 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...ponent/sample/feature/loadinganalysis/withspi/service/DynamicDependenciesWithSPIService.java

...alend/sdk/component/sample/feature/loadinganalysis/withspi/service/CustomizeClassLoader.java

...ponent/sample/feature/loadinganalysis/withspi/service/DynamicDependenciesWithSPIService.java

.../sample/feature/loadinganalysis/classloadertestlibrary/spiConsumers/AbstractSPIConsumer.java

...sdk/component/sample/feature/loadinganalysis/service/AbstractDynamicDependenciesService.java

...ciesConfiguration/service/DynamicDependenciesWithDynamicependenciesConfigurationService.java

...feature/loadinganalysis/withDataprepRunAnnotation/annotation/DynamicDependencySupported.java

sample-parent/sample-features/loading-analysis/README.md

Copilot

Pull request overview

Copilot reviewed 99 out of 110 changed files in this pull request and generated 12 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...ponent/sample/feature/loadinganalysis/withspi/service/DynamicDependenciesWithSPIService.java

...ple/feature/loadinganalysis/serviceproviderfromdependency/ServiceProviderFromDependency.java

...inganalysis/serviceproviderfromexternaldependency/ServiceProviderFromExternalDependency.java

...ample/feature/loadinganalysis/classloadertestlibrary/spiConsumers/DependencySPIConsumer.java

...sdk/component/sample/feature/loadinganalysis/service/AbstractDynamicDependenciesService.java

Copilot · 2026-02-10T16:04:50Z

sample-parent/sample-features/loading-analysis/loading-dependencies-common/pom.xml

+    </parent>
+
+    <!-- All artifacts with group starting by 'org.talend.sdk.component' are automatically excluded -->
+    <!-- So we changed the group to org.talend.sdk.sample -->


These comments say the group was changed to org.talend.sdk.sample, but the module inherits groupId from org.talend.sdk.component.loading-analysis (and the artifactId remains under that group). Please update/remove the comment to reflect the current POM structure to avoid confusion.

Suggested change

Copilot · 2026-02-10T16:04:50Z

sample-parent/sample-features/loading-analysis/README.md

+
+The `loading-analysis` module provides several TCK connector plugins designed to validate the `@DynamicDependencies` feature integration, at design time and runtime. It contains several connectors organized into two categories:
+
+- Firsts are connectors with a service that inherits `AbstractDynamicDependenciesService` and that check:


There are several typos in the README (e.g., Firsts, connnector's, exemple). Fixing these improves readability and keeps the sample documentation professional.

@copilot open a new pull request to apply changes based on this feedback

Copilot · 2026-02-10T16:04:50Z

sample-parent/sample-features/loading-analysis/README.md

+- artifactId: data-generator
+- version: 1.2512.0
+- connector's family: DataGenerator
+- connnector's name: DataGeneratorInput


There are several typos in the README (e.g., Firsts, connnector's, exemple). Fixing these improves readability and keeps the sample documentation professional.

Copilot · 2026-02-10T16:04:50Z

sample-parent/sample-features/loading-analysis/README.md

+| comment               | Check static dependency.                                                                                                                                                                                                                                                                                                                  |
+-----------------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
+```
+In this exemple we can see that we try to load the class `org.talend.sdk.component.sample.feature.loadinganalysis.config.Dependency` from the dependency `org.talend.sdk.component.loading-analysis:loading-dependencies-common`.


There are several typos in the README (e.g., Firsts, connnector's, exemple). Fixing these improves readability and keeps the sample documentation professional.

Copilot · 2026-02-10T16:24:31Z

@ypiel-talend I've opened a new pull request, #1166, to work on those changes. Once the pull request is ready, I'll request review from you.

* Initial plan * Fix typos in loading-analysis README.md Co-authored-by: ypiel-talend <29707101+ypiel-talend@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ypiel-talend <29707101+ypiel-talend@users.noreply.github.com>

…:Talend/component-runtime into ypiel/QTDI-1914_sample_connector_dyndeps

ypiel-talend and others added 30 commits October 23, 2025 00:32

chore(QTDI-1914): Sample dynamic schema connector.

f692cad

Add 2 params

e53256c

chore(QTDI-1914): remove unused option in dso, environment info manag…

b4705a0

…ement, better clazz location.

Add 2 connectors: dataset, datastore with tests

1a76af5

Add 2 connectors: dataset, datastore with tests

8c10ae1

chore(QTDI-1914): Some adjustments.

189ac9e

chore(QTDI-1914): Working unit test.

51c2838

chore(QTDI-1914): working dynamic dependencies connectors.

a921b04

fix labels

54714b7

chore(QTDI-1914): fix artifact group id for dependency.

d52d6eb

refactor junits

e55a7a4

add working directory in output

0c8e974

chore(QTDI-1914): Improve and unit test and fix labels.

3b18693

chore(QTDI-1914): Add a connector with same behavior as datapreprun.

360f13d

fix layout for dieOnError

136b654

Fix dataprepRunAnnotation connector

c3e7ad0

feat(QTDI-1914): Cleanings.

2417f80

Add Readme

fdde448

Merge branch 'master' into ypiel/QTDI-1914_sample_connector_dyndeps

55bd365

feat(QTDI-1914): try to execute a TCK connector to check if it is wel…

0572b53

…l loaded... to continue...

Merge branch 'ypiel/QTDI-1914_sample_connector_dyndeps' of github.com…

6ff4e06

…:Talend/component-runtime into ypiel/QTDI-1914_sample_connector_dyndeps

Add function to load depended component's depends

06da286

rename

caef44a

fix junit

15c4e2d

fix(QTDI-1914): some refactoring.

132e0d9

feat(QTDI-1914): Add a connector taht uses a SPI.

578c338

feat(QTDI-1914): remove unnecessary dependency.

2dc763d

feat(QTDI-1914): Add a test on the spi.

fabc258

feat(QTDI-1914): Change the SPI interface and add a unit test.

15759e1

ypiel-talend added 11 commits January 7, 2026 16:42

feat(QTDI-1914): Don't throw exception anymore if it misses a spi, ju…

ea29927

…st log + add an error messae in returned strings.

feat(QTDI-1914): Don't throw exception anymore if a resources from a …

dfe6b1f

…SPI is not loaded.

feat(QTDI-1914): Some improvements

56c3451

feat(QTDI-1914): Fix some SPI / deactivate the customer by default / …

258e6c0

…Don't fail if SPI can't be loaded.

feat(QTDI-1914): Simplify connectors forms.

a53a627

feat(QTDI-1914): Fix unit tests.

8e76aef

feat(QTDI-1914): Remove unused parameter to throw exception when a sp…

26160e5

…i in not found.

feat(QTDI-1914): A connector needs at least one parameter to be able …

ea5ea8a

…to transmit its dynamic dependencies.

feat(QTDI-1914): Add rootRepo/classpath/workingDir info in dyndepsWit…

7cbd5a1

…hSPI connector output records.

feat(QTDI-1914): Deactivate car/dependencies/scan in dynamic-dependen…

642c325

…cy-common module.

feat(QTDI-1914): Update documentation.

df43a2e

ypiel-talend requested a review from Copilot February 2, 2026 16:41

Copilot AI reviewed Feb 2, 2026

View reviewed changes

feat(QTDI-1914): Copilot code review.

ab3afe8

ypiel-talend changed the title ~~chore(QTDI-1914): Sample dynamic schema connector.~~ feat(QTDI-1914): Sample dynamic schema connector. Feb 6, 2026

ypiel-talend added 3 commits February 9, 2026 11:20

feat(QTDI-1914): Refactoring dynamic-dependencies module to loading-a…

e78dbd0

…nlysis.

feat(QTDI-1914): Fix after refactoring.

45f93fd

feat(QTDI-1914): Clean labels and icons after refactoring.

a17adc6

ypiel-talend requested a review from Copilot February 9, 2026 17:28

Copilot AI reviewed Feb 9, 2026

View reviewed changes

ypiel-talend added 2 commits February 10, 2026 11:46

feat(QTDI-1914): Update README.md after refactoring.

27d47be

feat(QTDI-1914): Copilot code review fixes.

b8e2994

ypiel-talend requested a review from Copilot February 10, 2026 16:01

Copilot AI reviewed Feb 10, 2026

View reviewed changes

Copilot AI mentioned this pull request Feb 10, 2026

Fix typos in loading-analysis README #1166

Merged

Copilot AI and others added 3 commits February 10, 2026 17:29

feat(QTDI-1914): Copilot code review fixes.

b0a424f

Merge branch 'ypiel/QTDI-1914_sample_connector_dyndeps' of github.com…

bf3c798

…:Talend/component-runtime into ypiel/QTDI-1914_sample_connector_dyndeps

	<!-- So we changed the group to org.talend.sdk.sample -->
	<!-- This module now inherits its groupId from the parent (org.talend.sdk.component.loading-analysis). -->


		The `loading-analysis` module provides several TCK connector plugins designed to validate the `@DynamicDependencies` feature integration, at design time and runtime. It contains several connectors organized into two categories:

		- Firsts are connectors with a service that inherits `AbstractDynamicDependenciesService` and that check:

Conversation

ypiel-talend commented Oct 22, 2025

Requirements

Why this PR is needed?

What does this PR adds (design/code thoughts)?

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonar-eks bot commented Feb 2, 2026

Quality Gate failed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

ypiel-talend Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants