ST6RI-906 Evaluation of functions from TrigFunctions #731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added general mechanism for model-level evaluation of library features. - Renamed some of the methods of interface LibraryFunction.
- Updated ModelLevelExpressionEvaluator to implement the new interface. - Changed "evaluator" parameters to be typed by the new interface.
- Corrected instantiateInvocation to copy instantiatedType from the original InvocationExpression, rather than the ownedTyping. - Updated the evaluation of Features so that unbound input parameters are considered to have a null value (rather than returning the Feature itself).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the (non-model-level) evaluation of all the functions from the Kernel Function Library package
TrigFunctions.Implemented Functions
The following functions from
TrigFunctionsare implemented in this PR.degradsincostancotarcsinarccosarctanAll functions are implemented using the corresponding functions from
java.lang.Math(even for those functions whose definition is given inTrigFunctions).In addition, the feature
TrigFunctions::piis implemented to have the valuejava.lang.Math.PI(even though this has lower precision than what is specified inTrigFunctions).Other Changes
TrigFunctions::pi.ExpressionEvaluatorinterface, which can be used to typeevaluatorparameters and fields more generally thanModelLevelExpressionEvaluator.ModelLevelExpressionEvaluatorimplementsExpressionEvaluator.org.omg.sysml.execution.expressions.ExpressionEvaluatorextension ofModelLevelExpressionEvaluator.instantiateInvocationto copyinstantiatedTypefrom the originalInvocationExpression, rather thanownedTyping.Featuresso that unbound input parameters are considered to have a null value (rather than returning theFeatureitself).