Allow configuration file to be specified via a environment variable#917
Allow configuration file to be specified via a environment variable#917luto wants to merge 1 commit intoSupervisor:mainfrom
Conversation
mnaberez
left a comment
There was a problem hiding this comment.
We can't merge any new features that don't have tests. Please remove the unrelated gitignore changes.
|
|
Thanks, I've merged #919. |
|
@mnaberez got tests now and they pass in the CI. Please let me know if you need anything else! :) |
mnaberez
left a comment
There was a problem hiding this comment.
I'll test this locally and if I don't find any issues, I'll merge it for the next feature release.
|
Thank you! :) |
|
@mnaberez any news on this? :) |
|
Hello, I came here searching for this. Any news on when it's planned to be merged/released? |
|
I'd have created this very pull request if this wasn't here already. What is the status of this, what is missing (if anything) before this can be merged? |
I reviewed it again and it looks fine to me. I intend to include it in the next release. |
|
Hi, I'd love to see this feature as well. Did anything change since your last review, what is required for this to be merged? |
|
We are still interested as well. |
Fixes #742
This PR enables the configuration file to be specified in the
$SUPERVISOR_CONFIGenvironment variable. Refer to the issue for further discussion.