Skip to content

Make the AssemblyLoadContexts not collectable #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KlaasWhite merged 1 commit into from
Dec 6, 2025
Merged

Make the AssemblyLoadContexts not collectable #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion StarMap.Core/ModRepository/ModAssemblyLoadContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ internal class ModAssemblyLoadContext : AssemblyLoadContext
private readonly AssemblyDependencyResolver _modDependencyResolver;

public ModAssemblyLoadContext(string modId, string modDirectory, AssemblyLoadContext coreAssemblyContext)
: base(isCollectible: true)
: base()
{
_coreAssemblyLoadContext = coreAssemblyContext;

Expand Down
2 changes: 1 addition & 1 deletion StarMap/GameAssemblyLoadContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ internal class GameAssemblyLoadContext : AssemblyLoadContext
private readonly AssemblyDependencyResolver _starMapDepdencyResolver;

public GameAssemblyLoadContext(string gamePath)
: base(isCollectible: true)
: base()
{
_gameDependencyResolver = new AssemblyDependencyResolver(gamePath);

Expand Down
Loading