Packaging: add dep on crudini & regenerate lockfiles/st2.lock #6329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lockfile diff: lockfiles/st2.lock [st2] == Upgraded dependencies == argcomplete 3.5.3 --> 3.6.2 attrs 25.1.0 --> 25.3.0 bcrypt 4.2.1 --> 4.3.0 eventlet 0.39.0 --> 0.39.1 iniconfig 2.0.0 --> 2.1.0 jinja2 3.1.5 --> 3.1.6 kombu 5.4.2 --> 5.5.2 mock 5.1.0 --> 5.2.0 pyasn1-modules 0.4.1 --> 0.4.2 python-json-logger 3.2.1 --> 3.3.0 pytz 2025.1 --> 2025.2 setuptools 75.3.0 --> 75.3.2 tzdata 2025.1 --> 2025.2 virtualenv 20.29.2 --> 20.30.0 == Added dependencies == crudini 0.9.5 iniparse 0.5
pull-request-size
bot
added
the
size/L
cognifloyd
added
enhancement
st2-packages
external dependency
size/L
cognifloyd
requested review from
a team,
amanda11,
guzzijones,
nzlosh,
rush-skills and
winem
nzlosh
approved these changes
Apr 11, 2025
guzzijones
approved these changes
Apr 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is working towards doing packaging via pantsbuild. Eventually, I hope to archive and stop using st2-packages.git.
This PR does 3 things:
crudinipex_binarytarget meant to be used when packaging deb/rpm with pants.lockfiles/st2.lockto include crudini (it has to be in thest2resolve because this is a transitive dep of the deb/rpm package targets).lockfiles/st2.lockto the legacy requirements files.In a follow-up PR (#6330 is a draft), I will add some
shell_commandtargets that modify the in-repo conf files during packaging. Currently st2-packages does this withsed, but it uses features that are only available in gnu sed, making it not very portable. Anyone that tried to run the sed commands on Mac--which would probably only happen during local development--the sed commands would fail. Crudini, on the other hand, is very portable and system agnostic. Plus, st2-packages.git uses crudini for several other things. So, crudini seems like a good way to edit the conf files on the fly without the portability concerns.crudiniwill not end up in the final st2 venv because we don't transitively depend on it from our code. We can explicitly include it later if that is helpful.Crudini links: