Packaging: Add systemd files to rpm/deb packages #6326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cognifloyd
requested review from
a team,
amanda11,
guzzijones,
nzlosh,
rush-skills and
winem
pull-request-size
bot
added
the
size/L
nzlosh
approved these changes
Apr 4, 2025
guzzijones
approved these changes
Apr 5, 2025
This was referenced Apr 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is working towards doing packaging via pantsbuild. Eventually, I hope to archive and stop using st2-packages.git.
The pants nfpm backend was activated in #6321.
Basic BUILD metadata for deb/rpm packages (
nfpm_deb_packageandnfpm_rpm_package) was added in #6325 along with the deb maintainer scripts and rpm scriptlets.This PR adds the systemd files (units and generators) cherry-picked in #6303 to the deb/rpm packages. To do this, we need to add
nfpm_content_filestargets to BUILD metadata and then make thenfpm_*_packagetargets depend on them.Once I did this, I realized that we were not running python formatters or linters on the systemd-generators, so this PR also fixes a few minor issues identified in them.