Packaging: Add distro_id field to nfpm_deb_package and nfpm_rpm_package targets

[cognifloyd]

This PR is working towards doing packaging via pantsbuild. Eventually, I hope to archive and stop using st2-packages.git.

This is a follow-up to #6323, resolving the TODO explained in #6323 (comment).

In pants-plugins/release, a new distro_id field is defined here:

st2/pants-plugins/release/target_types.py

Lines 22 to 24 in 00ff205

	class DistroIDField(StringField):
	nfpm_alias = "" # Not an nFPM field
	alias = "distro_id"

This field basically accepts an enum of valid_choices. These valid_choices should be a list of supported or soon-to-be-supported distros:

st2/pants-plugins/release/target_types.py

Lines 25 to 33 in 00ff205

	valid_choices = ( # officially supported (or planned future support)
	# ubuntu
	"focal",
	"jammy",
	"noble",
	# el
	"el8",
	"el9",
	)

And mark the field as required so that all BUILD targets have this field defined (if the field is registered for that target).

st2/pants-plugins/release/target_types.py

Line 34 in 00ff205

required = True

This registers the new field on the nfpm_deb_package and nfpm_rpm_package targets:

st2/pants-plugins/release/target_types.py

Lines 48 to 52 in 00ff205

	def rules():
	return [
	NfpmDebPackage.register_plugin_field(DistroIDField),
	NfpmRpmPackage.register_plugin_field(DistroIDField),
	]

To finish the field registration, the field rules get added to pants-plugins/release/register.py:

st2/pants-plugins/release/register.py

Lines 19 to 27 in 00ff205

	from release.rules import rules as release_rules
	from release.target_types import rules as release_target_types_rules
	def rules():
	return [
	*release_target_types_rules(),
	*release_rules(),
	]

Finally, replace the TODO with the value of the distro_id field here:

st2/pants-plugins/release/rules.py

Line 244 in 00ff205

distro_id=target[DistroIDField].value,