Fix chardet as fix requests #5105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
arm4b
reviewed
Dec 14, 2020
blag
approved these changes
Dec 14, 2020
Contributor
|
Should be fixed once I tweak StackStorm/st2ci#194, merge it in, and deploy it. |
Member
|
It makes sense to merge this PR as is ASAP, because it'll fix the other 3 e2e OS builds in this round. |
Contributor
|
Travis tests passed. I'm going to merge this in even with the U16 end-to-end tests failing since we need to get our CI passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We pin requests[security] but that has a check when running that chardet is < 3.1.0, but chardet is not listed as requirement with a pinned requirement.
Also fix typo in in-requirements.txt comments