Update console.js to run in environments without console#280
Open
BeatBroccoli wants to merge 5 commits intoSortableJS:masterfrom
Open
Update console.js to run in environments without console#280BeatBroccoli wants to merge 5 commits intoSortableJS:masterfrom
BeatBroccoli wants to merge 5 commits intoSortableJS:masterfrom
Conversation
I tried to run this component on NUXT SSR but it could not be served by Cloudflare because in that context the console is not reachable so an easy fix is just to provide an empty stub object
Author
|
I didn't compile the "dist" folder btw... those should be updated too. I can if required. Thanks. |
It is necessary to deal with elements that don't have id
before list2 added element, we can convert data from SortableJS#215
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to run this component on NUXT SSR but it could not be served by Cloudflare because in that context the console is not reachable so an easy fix is just to provide an empty stub object