Feature/admin create event #40
Conversation
|
|
src/app/components/admin-form-create-event/admin-form-create-event.component.html
Outdated
Show resolved
Hide resolved
src/app/components/admin-form-create-event/admin-form-create-event.component.html
Show resolved
Hide resolved
robertlb4
left a comment
robertlb4
left a comment
There was a problem hiding this comment.
This is a really good start and i'm just about ready to merge this first version in. Just need these last to changes to keep the code base a little cleaner
|
|
||
| const routes: Routes = []; | ||
| const routes: Routes = [ | ||
| { path: 'new/advertisingconfig', component: AdminFormCreateEventComponent }, |
There was a problem hiding this comment.
I think I've settled on a preference for: new/campaign, manage/campaign
I think that is clean and understandable
There was a problem hiding this comment.
gotcha, i've updated it. Since I was able to use the tabs, this path might be better named something more general since it includes both create and manage functionalities. path: 'campaigns' Thoughts?
There was a problem hiding this comment.
Not a bad Idea. I like the idea of having the 2 routes available for us. In the future we can use them to decide which tab we start on when the component loads. So, if a link form another part of the site goes to manage/campaign then it will go to the same component but start on the manage tab.
I see you are changing it in the other PR, so it will be fine here for now.
|
PR has been accepted. Note: there are requested changes pending on another #45 |
Describe the changes in this Pull Request
includes admin create event component with tabs to name event, control ad times, upload content, and manage content for event queue
What issue(s) does this Pull Request resolve?
Resolves and closes issue #20