fix(socket-npm): fixing a bug on how the cli bin is passed to the wrapper#985
Merged
fix(socket-npm): fixing a bug on how the cli bin is passed to the wrapper#985
Conversation
jdalton
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bin/npm-cli.js- Incorrect argument passing:Before:
shadowNpmBin('npm', process.argv.slice(2), {...})After:
shadowNpmBin(process.argv.slice(2), {...})The function doesn't expect a binary name as the first argument. Passing 'npm' caused it to be interpreted as the first CLI argument, shifting all subsequent arguments by one position.
bin/npx-cli.js- Wrong module and function:Before:
dist/shadow-npm-bin.js(npm module)shadowNpmBin('npx', ...)(npm function)After:
dist/shadow-npx-bin.js(npx module)shadowNpxBin(...)(npx function)Using the npm wrapper for npx commands, and passing 'npx' as an argument caused the same argument-shifting issue.
Note
Fixes npm and npx CLI wrappers to pass args correctly and uses the proper npx wrapper/module.
bin/npm-cli.js: Remove binary name fromshadowNpmBin(...)call; pass onlyprocess.argv.slice(2).bin/npx-cli.js: Requiredist/shadow-npx-bin.jsand callshadowNpxBin(...)withprocess.argv.slice(2)(no binary name).Written by Cursor Bugbot for commit a5c9cd3. Configure here.