Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
| path.dirname(outputFilePath), | ||
| '--socket-mode', | ||
| constants.DOT_SOCKET_DOT_FACTS_JSON, | ||
| outputFilePath, |
There was a problem hiding this comment.
Bug: Coana socket-mode argument receives full path instead of filename
The --socket-mode Coana argument now receives outputFilePath (which can be a full path like ./reports/analysis.json) instead of just a filename. The original code pattern passed a filename to --socket-mode and a directory to --output-dir. When a user specifies --output ./reports/analysis.json, the code passes --output-dir ./reports and --socket-mode ./reports/analysis.json. If Coana combines these (placing the --socket-mode value inside --output-dir), the output could be written to an incorrect nested path. The --socket-mode value likely needs to be path.basename(outputFilePath) to maintain the expected behavior.
There was a problem hiding this comment.
The --ouput-dir is actually not even used when --socket-mode is set so this comment can be ignored. I'll get the --output-dir removed completely, but I have to update the Coana CLI first. Currently it complains if you don't provide it with an output directory.
--output <scan-report.json>flag tosocket scan reach.14.12.107.Note
Adds --output/-o to
socket scan reachto write reports to a custom .json path (plumbed through execution and logging), and updates Coana CLI to v14.12.107 with version bump.socket scan reach--output <path>.json(alias-o) to write reachability report to a custom JSON file; validates extension is.json.outputPaththroughcmd-scan-reach.mts→handle-scan-reach.mts→perform-reachability-analysis.mts→output-scan-reach.mts.--output-dirand--socket-mode.--output/-oacceptance and failures (non-.json/uppercase extension); snapshots updated for help/examples.@coana-tech/clito14.12.107and update lockfile.1.1.39and CHANGELOG.Written by Cursor Bugbot for commit 10de5ce. Configure here.