refactor(lib-internal): replace require() with ES module imports#891
Closed
refactor(lib-internal): replace require() with ES module imports#891
Conversation
Convert lazy require() calls to static ES module imports for better bundling and tree-shaking. Aligns with broader effort to eliminate dynamic require() usage across the codebase. Changes: - package-extensions.ts: Import @yarnpkg/extensions as ES module - prompts.ts: Replace require() with static imports for @inquirer/* modules - Simplify raw variable assignments (no more default ?? fallback)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Convert lazy
require()calls to static ES module imports in lib-internal package for better bundling and tree-shaking.Changes
package-extensions.tsprompts.tsBenefits
✅ Better bundling - static imports enable tree-shaking
✅ Cleaner code - no more default ?? fallback patterns
✅ Consistent style - aligns with ES module best practices
✅ Improved performance - eliminates runtime require() resolution
Test Plan
Impact
Low risk - Simple import conversion with no logic changes. The same modules are loaded, just with static imports instead of dynamic require().