Fixes bug in MASExampleUpdateView#489
Open
ShannonChenCHN wants to merge 1 commit intoSnapKit:masterfrom
ShannonChenCHN:master
Open
Fixes bug in MASExampleUpdateView#489ShannonChenCHN wants to merge 1 commit intoSnapKit:masterfrom ShannonChenCHN:master
ShannonChenCHN wants to merge 1 commit intoSnapKit:masterfrom
ShannonChenCHN:master
Conversation
When tapped the `growingButton`, it didn't grow. Probably we need to change the width constraint priority of `growingButton` from low to medium. I have tried this fix on my project, and it worked fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bug found in iOS Example Project.
When I tapped the
growingButtoninMASExampleUpdateView, the button didn't grow. Probably we need to change the width constraint priority ofgrowingButtonfrom low to medium. I have tried this fix on my project, and it worked fine.When I printed all constraints of
growingButton, and I got this:So, It looks like
make.width.lessThanOrEqualTo(self);makes a constraint with a default priority( NSLayoutPriorityRequired).