Enforce section claims prior to syntax initialization, rather than after #8395
+102
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures Sections get priority over ExrpSecs, and still errors if 2+ exprsecs are in a line together without a clear owner (a pure Section) Also fixes a potion bug with infinite() comparing a nullable Integer with an int.
sovdeeth
added
the
bug
sovdeeth
requested review from
Pesekjak and
UnderscoreTud
and removed request for
a team
skriptlang-automation
bot
added
the
needs reviews
Pesekjak
approved these changes
Jan 22, 2026
Absolutionism
approved these changes
Jan 22, 2026
skriptlang-automation
bot
added
patch-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The new potion effect exprsec highlighted a longstanding flaw in ExprSec parsing. Children can claim sections before their parents, leading to unexpected parsing errors within the section and unintuitive parsing when using a exprsec within a clear section like an if statement.
Solution
Syntaxes now claim prior to initialization (prior to children being able to claim) and unclaim if init fails.
Ensures Sections get priority over ExrpSecs, and still errors if 2+ exprsecs are in a line together without a clear owner (a pure Section)
Also fixes a potion bug with infinite() comparing a nullable Integer with an int.
Testing Completed
expression sections.sk
Supporting Information
Completes: none
Related: none
AI assistance: none