-
Notifications
You must be signed in to change notification settings - Fork 3
Add comment_command_flags and comment_package_manager params #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
005d247 to
7c357a3
Compare
7c357a3 to
8dacdbe
Compare
|
@gonzaloriestra can you follow the naming of inputs in this PR #32 |
6cd7c1b to
fb962c3
Compare
|
@alex-page updated, thanks! Should I just merge and use |
7a92743 to
e03ae1a
Compare
|
@gonzaloriestra I can do a release tomorrow. Just merge to |
|
@alex-page the main branch seems to be broken. I tried first with this branch and it didn't work, although it didn't show any error. Then I switched to main (after fixing this typo), and I got the same result: https://github.com/Shopify/cli/actions/runs/19293916160/job/55171040211 Could you please have a look? |
a01720c to
f536e4a
Compare
3ba8191 to
4c9288a
Compare
It seems like it is green in CI? Is there a failing run or is it just not publishing? |
|
@alex-page it's not failing, but not publishing. It just finishes and does nothing. |
72d73ea to
ee98df3
Compare
I'm adding two optional params:
comment_command_flags: to append to the global install commandcomment_package_manager: to use for the global install command instead of the inferred oneWe want them to simplify the snapit message in the CLI: