Skip to content

Conversation

@gonzaloriestra
Copy link
Contributor

@gonzaloriestra gonzaloriestra commented Aug 27, 2025

I'm adding two optional params:

  • comment_command_flags: to append to the global install command
  • comment_package_manager: to use for the global install command instead of the inferred one

We want them to simplify the snapit message in the CLI:

Before After
28-36-uegu6-4wnyj 28-37-ol36n-easws

@gonzaloriestra gonzaloriestra force-pushed the registry-and-package-manager branch 3 times, most recently from 005d247 to 7c357a3 Compare August 28, 2025 08:22
@gonzaloriestra gonzaloriestra force-pushed the registry-and-package-manager branch from 7c357a3 to 8dacdbe Compare August 28, 2025 08:34
@gonzaloriestra gonzaloriestra marked this pull request as ready for review August 28, 2025 08:39
@alex-page
Copy link
Member

@gonzaloriestra can you follow the naming of inputs in this PR #32

@gonzaloriestra
Copy link
Contributor Author

@alex-page updated, thanks! Should I just merge and use Shopify/snapit@main, or are you planning to cut a release?

@gonzaloriestra gonzaloriestra force-pushed the registry-and-package-manager branch from 7a92743 to e03ae1a Compare November 11, 2025 11:10
@alex-page
Copy link
Member

@gonzaloriestra I can do a release tomorrow. Just merge to main

@gonzaloriestra gonzaloriestra changed the title Add shopify_registry and package_manager params Add comment_shopify_registry and comment_package_manager params Nov 11, 2025
@gonzaloriestra gonzaloriestra changed the title Add comment_shopify_registry and comment_package_manager params Add comment_shopify_registry and comment_command_flags params Nov 11, 2025
@gonzaloriestra
Copy link
Contributor Author

@alex-page the main branch seems to be broken. I tried first with this branch and it didn't work, although it didn't show any error.

Then I switched to main (after fixing this typo), and I got the same result: https://github.com/Shopify/cli/actions/runs/19293916160/job/55171040211

Could you please have a look?

@alex-page alex-page closed this Nov 12, 2025
@alex-page alex-page reopened this Nov 12, 2025
@alex-page
Copy link
Member

@alex-page the main branch seems to be broken. I tried first with this branch and it didn't work, although it didn't show any error.

Then I switched to main (after fixing #45), and I got the same result: https://github.com/Shopify/cli/actions/runs/19293916160/job/55171040211

It seems like it is green in CI? Is there a failing run or is it just not publishing?

@gonzaloriestra
Copy link
Contributor Author

@alex-page it's not failing, but not publishing. It just finishes and does nothing.

@gonzaloriestra gonzaloriestra changed the title Add comment_shopify_registry and comment_command_flags params Add comment_command_flags and comment_package_manager params Jan 12, 2026
@gonzaloriestra gonzaloriestra force-pushed the registry-and-package-manager branch from 72d73ea to ee98df3 Compare January 19, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants