feat(studio-mcp): add workflow CRUD tools with task-based runs#311
feat(studio-mcp): add workflow CRUD tools with task-based runs#311betterclever merged 2 commits intomainfrom
Conversation
Signed-off-by: betterclever <paliwal.pranjal83@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9c5d3f847f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| edges: z.infer<typeof WorkflowEdgeSchema>[]; | ||
| viewport?: z.infer<typeof WorkflowViewportSchema>; | ||
| }) => { | ||
| const gate = this.checkPermission(auth, 'workflows.create'); |
There was a problem hiding this comment.
Expose workflow mutation permissions to API-key auth
This new gate checks workflows.create (and similarly workflows.update/workflows.delete below), but API-key auth currently only carries workflows.run/list/read (see backend/src/auth/auth.guard.ts normalization and backend/src/api-keys/dto/api-key.dto.ts), so these flags are always undefined and checkPermission always denies API-key callers. In practice, all new workflow mutation MCP tools become unusable for API-key clients regardless of key configuration until the permission model is wired end-to-end.
Useful? React with 👍 / 👎.
Signed-off-by: betterclever <paliwal.pranjal83@gmail.com>
|
Addressed the API-key permission wiring feedback in . Changes made:
Validated with:
|
|
Follow-up: addressed the API-key permission wiring feedback in commit abd21c3. Implemented:
Validation:
|
Summary
create_workflow,update_workflow,update_workflow_metadata, anddelete_workflowto Studio MCPrun_workflowflow (Task API + monitor loop)Validation
bun --cwd backend test src/studio-mcp/__tests__/studio-mcp.service.spec.tstsc --buildand full test suite)