Skip to content

Conversation

@Hanmac
Copy link
Collaborator

@Hanmac Hanmac commented Nov 5, 2025

WIP so see if something is broken

Dependencies that blocks 8.0 Version:

  • composer why-not vimeo/psalm "7.0.0-beta11"
    psalm/plugin-phpunit 0.19.5 requires vimeo/psalm (dev-master || ^6.10.0)

  • composer why-not symfony/cache "v8.0.0-BETA1"
    doctrine/doctrine-bundle 3.0.0 requires symfony/cache (^6.4 || ^7.0)

  • composer why-not symfony/doctrine-bridge "v8.0.0-BETA1"
    doctrine/doctrine-bundle 3.0.0 requires symfony/doctrine-bridge (^6.4.3 || ^7.0.3)

  • composer why-not symfony/dependency-injection 8.0.0-BETA2
    matthiasnoback/symfony-dependency-injection-test 6.1.0 requires symfony/dependency-injection (^5.4 || ^6.2 || ^7.0)

@Hanmac
Copy link
Collaborator Author

Hanmac commented Dec 1, 2025

Right now, it's just vimeo/psalm that is blocking:
psalm/plugin-phpunit > vimeo/psalm > symfony/console: ^6.0 || ^7.0

other projects removed psalm checks from their code

@loevgaard
Copy link
Member

loevgaard commented Dec 1, 2025

Yeah, just remove that and add phpstan :D

@Hanmac Hanmac marked this pull request as ready for review December 1, 2025 11:02
@Hanmac Hanmac requested a review from loevgaard December 1, 2025 11:16
@loevgaard
Copy link
Member

Set reportUnmatchedIgnoredErrors: false inside the phpstan config

@Hanmac
Copy link
Collaborator Author

Hanmac commented Dec 1, 2025

Can we drop PHP 8.1 if it's only supported til "31 Dec 2025"?

@loevgaard
Copy link
Member

Not a fan and I believe it shouldn't. Is there a good case for it?

@Hanmac
Copy link
Collaborator Author

Hanmac commented Dec 1, 2025

Stupid phpunit
in < 11.0, "once" and "never" are static methods (PHP 8.1)
in >= 11.0, "once" and "never" are instance methods (PHP 8.2)

phpunit itself doesn't complain about when I try to call the statics as instance variables,
but phpstan does.

@Hanmac
Copy link
Collaborator Author

Hanmac commented Dec 1, 2025

PHP 8.5 does pass too

Copy link
Member

@loevgaard loevgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🎉

@Hanmac Hanmac merged commit eb7a918 into Setono:master Dec 1, 2025
64 checks passed
@Hanmac Hanmac deleted the symfony8 branch December 1, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants