-
Notifications
You must be signed in to change notification settings - Fork 5
feature/loader #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/loader #190
Conversation
Image promise function was garbage
|
Yeah so the really long builds is a result of webpack increasing the size of To avoid this, we would need to pull Static class functions that take an instance of the class seem problematic in our use case anyways, so hoisting these elsewhere is probably in our best interests. I might punt on this specific feature and do some PRs on the other ones (like |
The necessary changes to avoid the issue are in #200 and #201. I have merged the latest of #201 into this branch and made it the base for this PR. I have tested this and am able to build repeatedly without |
TrevorBurgoyne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
loader is very cool, and i like the general init refactor
This ensures the style is properly removed when the div is removed
|
@TrevorBurgoyne I consolidated to a single init (the async one) without any delays, and merged the latest main through the whole chain. #200 and #201 are approved, so if this is approved I'll merge them all into #202 so we can release them all together. |
TrevorBurgoyne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Loader
Closes #25.
Description
staggered_ulabel_initwhich displays the screen earlier and adds a configurable delay between each step. This is intended to help visualize/debug the loading process, and demonstrate features like the loaderbuild-dev-and-demonpm scriptThe "staggered" init is
asyncto allow the delays to run. TheULabel.load_image_promisewasn't playing nicely withasync, so I opted to use.decode()instead (why wasn't this done in the first place?).I resisted the urge to completely rearrange and init process in this PR, but now there is a place to do so if we want to optimize in the future.
The production build for this is way slower than previously, which I suspect is due to the static function calls (index.jsandinitializer.tsboth call each other so there's some resolution that webpack has to handle). I'm going to leave this as a draft until I can solve this, or we decide that we don't care.Production build size issues solved by #200 and #201.
PR Checklist
maintarget branchpackage.jsonhas been bumped since last releasepackage.jsonandsrc/version.jsnpm installandnpm run buildAFTER bumping the version numberapi_spec.md)changelog.mdBreaking API Changes
maybe