-
Notifications
You must be signed in to change notification settings - Fork 1
Feature/toggle class keybind #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds an input component for customizable user input fields that can trigger AWS Lambda functions, implements keybinds for toggling class values in MultiClassGrid, fixes bugs, and adds pagination for S3 responses.
- Add new
Inputcomponent with customizable form fields and AWS Lambda integration - Fix S3 Browser bug caused by incorrect property reference in Dropdown component
- Implement pagination for S3 API responses to handle 500+ items efficiently
- Add keybinds (1, 2, etc.) to toggle between class values in MultiClassGrid
Reviewed Changes
Copilot reviewed 21 out of 22 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| terraform-backend/lambdas/utils/s3_utils.py | Add pagination support and typing for S3 operations |
| terraform-backend/lambdas/utils/lambda_utils.py | Add utility function for invoking Lambda functions |
| terraform-backend/lambdas/s3_browser.py | Update to support pagination in S3 folder browsing |
| terraform-backend/lambdas/input.py | New Lambda function for triggering input-based Lambda calls |
| terraform-backend/lambdas.tf | Add Terraform configuration for new input Lambda functions |
| terraform-backend/iam.tf | Add IAM policy attachment for Lambda invocation permissions |
| react-frontend/src/css/Input.css | Styling for the new Input component |
| react-frontend/src/components/MultiClassGridImage.js | Add IDs for class selectors to support keybind functionality |
| react-frontend/src/components/Input.js | New React component for user input forms with Lambda integration |
| react-frontend/src/components/Dropdown.js | Fix bug where incorrect property was referenced for disable state |
| react-frontend/src/QASM/utils.js | Fix overlay ID reference and improve error handling |
| react-frontend/src/QASM/lambda_handlers.js | Add handler for input Lambda triggers and update image loading |
| react-frontend/src/QASM/grid_utils.js | Implement class toggle keybinds and improve async loading order |
| react-frontend/src/QASM/api_utils.js | Add pagination support for API calls |
| react-frontend/src/App.js | Register new Input component |
| react-frontend/public/electron_constants.js | Add constants for Input component |
| react-frontend/package.json | Update version and ulabel dependency |
| react-frontend/license-config.json | Add license configuration file |
| react-frontend/default-config.json | Add example configuration for Input component |
| react-frontend/QASM.py | Add input to valid components and add sleep for S3 setup |
| README.md | Document Input component configuration and class toggle keybinds |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 21 out of 22 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Input, Toggle Class, Bug Fixes
What?
inputcomponentDropdowncomponentMultiClassGrid1for toggling through the first class values,2for the next, etcWhy?
Checks:
npm run qasm-push -- --config_path "./default-config.json"to update the Demo siteBreaking Changes