Fix inverted ChatMix level for SteelSeries Arctis 7/Pro (#475) #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The chatmix level calculation had game and chat directions swapped: max game volume produced level > 64 (indicating chat), and vice versa. This bug originated in the old C implementation (steelseries_arctis_7.c) and was carried over verbatim during the C++ rewrite (#443). It went unnoticed because the old code returned a plain int with no defined semantics for direction, users just saw a changing number. The bug became observable once ChatmixResult defined < 64 as game and > 64 as chat.
Contributor
|
That corrected the level value. But the percentages are still wrong. These lines: HeadsetControl/lib/devices/steelseries_arctis_7.hpp Lines 170 to 171 in 3785e28 Need to be changed to: int game_pct = (game == 0) ? 100 : map(game, 191, 255, 0, 100);
int chat_pct = (chat == 0) ? 100 : map(chat, 191, 255, 0, 100); |
…475) The map() output range was backwards: neutral position (255) mapped to 0% instead of 100%. Swap range so percentages correctly reflect volume.
Owner
Author
|
@TheBill2001 Can you please try again |
Contributor
|
Yep, everything is correct now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chatmix level calculation had game and chat directions swapped: max game volume produced level > 64 (indicating chat), and vice versa.
This bug originated in the old C implementation (steelseries_arctis_7.c) and was carried over verbatim during the C++ rewrite (#443). It went unnoticed because the old code returned a plain int with no defined semantics for direction, users just saw a changing number. The bug became observable once ChatmixResult defined < 64 as game and > 64 as chat.