Skip to content

Conversation

@ammodev
Copy link
Contributor

@ammodev ammodev commented Jan 22, 2026

This superseeds #168

Copilot AI review requested due to automatic review settings January 22, 2026 16:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors the message builder color system to provide better organization and type-specific prefixes. It introduces a new interface-based architecture for color builders and adds dedicated prefix components for different message types (INFO, SUCCESS, WARNING, ERROR).

Changes:

  • Refactored color builder methods into separate interface files for better organization
  • Added new type-specific prefix components (INFO_PREFIX, SUCCESS_PREFIX, WARNING_PREFIX, ERROR_PREFIX)
  • Consolidated number handling in SurfComponentBuilder using a single Number type parameter
  • Organized Minecraft colors into a dedicated subdirectory

Reviewed changes

Copilot reviewed 33 out of 34 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Colors.kt Modified PREFIX, added INFO_PREFIX, SUCCESS_PREFIX, WARNING_PREFIX, ERROR_PREFIX components
SurfComponentBuilder.kt Refactored to use ComponentBuilderColors interface, deprecated old prefix methods, consolidated number handling
ComponentBuilderColor.kt New base interface with coloredComponent helper methods
ComponentBuilderColors.kt New aggregator interface combining SurfComponentBuilderColors and MinecraftComponentBuilderColors
SurfComponentBuilderColors.kt Aggregates all Surf-specific color builder interfaces
MinecraftComponentBuilderColors.kt Aggregates all Minecraft color builder interfaces
*ComponentBuilderColor.kt (various) Individual color builder interfaces for each color type
surf-api-core-api.api Updated public API signatures reflecting the refactoring
gradle.properties Version bump from 2.54.3 to 2.55.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ammodev ammodev merged commit e726798 into version/1.21.11 Jan 22, 2026
10 checks passed
@ammodev ammodev deleted the feat/better-prefixes branch January 22, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants