Conversation
query to be run retrospectively.
skeating
reviewed
Jan 30, 2026
Collaborator
skeating
left a comment
skeating
left a comment
There was a problem hiding this comment.
Can you add a test please
for where hashing should have occurred
jeremyestein
force-pushed
the
jeremy/write-hashes
branch
from
0b70830 to
04bb57b
Compare
jeremyestein
force-pushed
the
jeremy/write-hashes
branch
from
fbd69e3 to
518f6d2
Compare
files match each other where appropriate
jeremyestein
force-pushed
the
jeremy/write-hashes
branch
from
8246092 to
a6bf4b6
Compare
Collaborator
Author
|
Added a test for the whole snakemake pipeline |
thompson318
approved these changes
Feb 5, 2026
Collaborator
thompson318
left a comment
thompson318
left a comment
There was a problem hiding this comment.
This looks sensible to me and works locally. A couple of very minor comments. Might also be worth added a note re using upto date docker compose for local testing in develop.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #36 .
To build images with
build-push-actionaction, the env_var files have to exist, hence creating them in GHA.The main content of this PR is in the snakemake rule
make_daily_hash_lookup, but I also refactored it a bit to put all the file path calculations in one place.