Conversation
Closed
5 tasks
access directly by service name on the docker network. Just let it pick an ephemeral one.
jeremyestein
force-pushed
the
jeremy/real-hashing
branch
from
8e5c701 to
eb2c16a
Compare
Merge branch 'jeremy/write-hashes' into jeremy/real-hashing
are using real hashes
the intended values
jeremyestein
force-pushed
the
jeremy/real-hashing
branch
from
9d07937 to
25bfc47
Compare
to build here too.
jeremyestein
force-pushed
the
jeremy/real-hashing
branch
from
5181f5a to
982e3aa
Compare
thompson318
approved these changes
Feb 5, 2026
Collaborator
thompson318
left a comment
thompson318
left a comment
There was a problem hiding this comment.
This works for me, producing the correct hashes in testing. Instructions to set up the hasher were straightforward and clear.
Found 1 bad link to fix before merge.
Co-authored-by: Stephen Thompson <s.thompson@ucl.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes most of #6
The core of this change is in
src/pseudon/hashing.py: it now points to the real hasher HTTP service instead of doing its own toy hash.I decided to use the full length hashes provided to avoid weakening the security, although they are rather long and we might have to monitor how much disk space that takes up.
Some config was needed to get the hasher working in Github Actions. There is also some code to aid debugging (printing hasher logs etc).
The dev key vault works and I have created the one-off secret that it needs. Dev key vault creds are in the secrets store for this repo and referenced in the Actions workflow.