Revert "BREAKING: Make random_mod platform-independent"#1017
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1017 +/- ##
==========================================
- Coverage 79.88% 79.86% -0.02%
==========================================
Files 163 163
Lines 17711 17709 -2
==========================================
- Hits 14148 14144 -4
- Misses 3563 3565 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
48b598e to
a90e2ca
Compare
This reverts commit 62b90b8 (#1010) We're noticing CI failures on cross which seem to be related to this change, e.g. https://github.com/RustCrypto/crypto-bigint/actions/runs/19647957432/job/56267760132 It looks like it's potentially getting stuck in an infinite loop.
a90e2ca to
4d9ee88
Compare
|
Yeah not sure exactly what's happening |
|
I guess without that removed masking code in |
|
Not sure that’s it; the i686 tests were passing, and in a different repo I confirmed that that algorithm worked against wasm32. When I get a chance I’ll give a go at trying to reproduce the cross environment and see if I can figure out what’s going on. Anyone else who’d like to take a swing at it, be my guest. |
|
Notably the cross test that was seemingly wedged was actually on |
This reverts commit 62b90b8 (#1010)
We're noticing CI failures on cross which seem to be related to this
change, e.g.
https://github.com/RustCrypto/crypto-bigint/actions/runs/19647957432/job/56267760132
It looks like it's potentially getting stuck in an infinite loop.
cc @mrdomino @fjarri